-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port threads to Django syntax #1432
Conversation
@brylie you can take a look at this screen record to gain insight into the final design: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this PR looks good. Let's just attach the related Civi
queries for problems, causes, and solutions directly to the Thread
class.
Let's also discuss the performance implications of civi/solution counts on the Thread
model and where/whether those counts will be used.
Let's use #1152 as the parent issue for the pull request that entirely removes Backbone.js.
If we add those issues with good descriptions, we can label them with |
Related to #1152
I will create new issues to fix creation of new civis, voting, adding response and recommended civis. I feel like there are some leftovers. And we need to remove thread.js. file. I am planning to create another issue (a similar one to #1151) to clean up.