Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port threads to Django syntax #1432

Merged
merged 10 commits into from
Oct 16, 2022
Merged

Conversation

gorkemarslan
Copy link
Collaborator

@gorkemarslan gorkemarslan commented Oct 13, 2022

Related to #1152

I will create new issues to fix creation of new civis, voting, adding response and recommended civis. I feel like there are some leftovers. And we need to remove thread.js. file. I am planning to create another issue (a similar one to #1151) to clean up.

@gorkemarslan gorkemarslan marked this pull request as draft October 13, 2022 05:13
@gorkemarslan
Copy link
Collaborator Author

@brylie you can take a look at this screen record to gain insight into the final design:

74c42fc8afcf696fec57494923e1a8d2d67908f5

@gorkemarslan gorkemarslan marked this pull request as ready for review October 13, 2022 20:43
Copy link
Member

@brylie brylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this PR looks good. Let's just attach the related Civi queries for problems, causes, and solutions directly to the Thread class.

Let's also discuss the performance implications of civi/solution counts on the Thread model and where/whether those counts will be used.

project/core/templates/static/less/thread.less Outdated Show resolved Hide resolved
project/threads/models.py Show resolved Hide resolved
project/threads/models.py Outdated Show resolved Hide resolved
project/threads/urls/urls.py Outdated Show resolved Hide resolved
project/threads/urls/urls.py Outdated Show resolved Hide resolved
project/threads/views.py Outdated Show resolved Hide resolved
@brylie
Copy link
Member

brylie commented Oct 14, 2022

And we need to remove thread.js. file. I am planning to create another issue

Let's use #1152 as the parent issue for the pull request that entirely removes Backbone.js.

I will create new issues to fix creation of new civis, voting, adding response and recommended civis.

If we add those issues with good descriptions, we can label them with hacktoberfest so other contributors might help.

@gorkemarslan gorkemarslan merged commit 555f32e into CiviWiki:develop Oct 16, 2022
@gorkemarslan gorkemarslan deleted the port-threads branch October 16, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants